fix: argocd notification controller app client permission issue #16057
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… namespaced appClient Signed-off-by: May Zhang <may_zhang@intuit.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #16057 +/- ##
==========================================
- Coverage 49.55% 49.53% -0.03%
==========================================
Files 269 269
Lines 46595 46627 +32
==========================================
+ Hits 23091 23097 +6
- Misses 21232 21259 +27
+ Partials 2272 2271 -1
☔ View full report in Codecov by Sentry. |
mayzhang2000
changed the title
leoluz
requested changes
Oct 23, 2023
| if len(applicationNamespaces) == 0 { | ||
| appClient = namespaceableAppClient.Namespace(namespace) | ||
| } | ||
| appClient = client.Resource(applications) |
There was a problem hiding this comment.
I think this line needs to be removed. Maybe we forgot to clean it up during the fix..
Signed-off-by: May Zhang <may_zhang@intuit.com>
ymktmk
pushed a commit
to ymktmk/argo-cd
that referenced
this pull request
Oct 29, 2023
…oproj#16057) * if applicationNamespaces is not provided as input parameter, then use namespaced appClient Signed-off-by: May Zhang <may_zhang@intuit.com> * fix go lint error Signed-off-by: May Zhang <may_zhang@intuit.com> --------- Signed-off-by: May Zhang <may_zhang@intuit.com>
13 tasks
|
/cherry-pick release-2.9 |
|
/cherry-pick release-2.8 |
|
/cherry-pick release-2.7 |
|
/cherry-pick release-2.6 |
crenshaw-dev
pushed a commit
that referenced
this pull request
Oct 30, 2023
) (#16159) * if applicationNamespaces is not provided as input parameter, then use namespaced appClient * fix go lint error --------- Signed-off-by: May Zhang <may_zhang@intuit.com> Co-authored-by: May Zhang <may_zhang@intuit.com>
crenshaw-dev
pushed a commit
that referenced
this pull request
Oct 30, 2023
) (#16160) * if applicationNamespaces is not provided as input parameter, then use namespaced appClient * fix go lint error --------- Signed-off-by: May Zhang <may_zhang@intuit.com> Co-authored-by: May Zhang <may_zhang@intuit.com>
crenshaw-dev
pushed a commit
that referenced
this pull request
Oct 30, 2023
) (#16161) * if applicationNamespaces is not provided as input parameter, then use namespaced appClient * fix go lint error --------- Signed-off-by: May Zhang <may_zhang@intuit.com> Co-authored-by: May Zhang <may_zhang@intuit.com>
mayzhang2000
added a commit
to mayzhang2000/argo-cd
that referenced
this pull request
Oct 30, 2023
…oproj#16057) * if applicationNamespaces is not provided as input parameter, then use namespaced appClient Signed-off-by: May Zhang <may_zhang@intuit.com> * fix go lint error Signed-off-by: May Zhang <may_zhang@intuit.com> --------- Signed-off-by: May Zhang <may_zhang@intuit.com>
3 tasks
crenshaw-dev
pushed a commit
that referenced
this pull request
Oct 31, 2023
) (#16166) * if applicationNamespaces is not provided as input parameter, then use namespaced appClient * fix go lint error --------- Signed-off-by: May Zhang <may_zhang@intuit.com>
jmilic1
pushed a commit
to jmilic1/argo-cd
that referenced
this pull request
Nov 13, 2023
…oproj#16057) * if applicationNamespaces is not provided as input parameter, then use namespaced appClient Signed-off-by: May Zhang <may_zhang@intuit.com> * fix go lint error Signed-off-by: May Zhang <may_zhang@intuit.com> --------- Signed-off-by: May Zhang <may_zhang@intuit.com> Signed-off-by: jmilic1 <70441727+jmilic1@users.noreply.github.com>
vladfr
pushed a commit
to vladfr/argo-cd
that referenced
this pull request
Dec 13, 2023
…oproj#16057) * if applicationNamespaces is not provided as input parameter, then use namespaced appClient Signed-off-by: May Zhang <may_zhang@intuit.com> * fix go lint error Signed-off-by: May Zhang <may_zhang@intuit.com> --------- Signed-off-by: May Zhang <may_zhang@intuit.com>
tesla59
pushed a commit
to tesla59/argo-cd
that referenced
this pull request
Dec 16, 2023
…oproj#16057) * if applicationNamespaces is not provided as input parameter, then use namespaced appClient Signed-off-by: May Zhang <may_zhang@intuit.com> * fix go lint error Signed-off-by: May Zhang <may_zhang@intuit.com> --------- Signed-off-by: May Zhang <may_zhang@intuit.com>
Hariharasuthan99
pushed a commit
to AmadeusITGroup/argo-cd
that referenced
this pull request
Jun 16, 2024
…oproj#16057) * if applicationNamespaces is not provided as input parameter, then use namespaced appClient Signed-off-by: May Zhang <may_zhang@intuit.com> * fix go lint error Signed-off-by: May Zhang <may_zhang@intuit.com> --------- Signed-off-by: May Zhang <may_zhang@intuit.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When argocd notification controller starts without --application-namespaces, following error is in the log
cannot list resource "applications" in API group "argoproj.io" at the cluster scope
Checklist: